Question posted by: Keith G Hicks
(Guest)
on
August 26th, 2008 08:35 PM
I'm having a lot of trouble with "file in use" errors in my "folder watcher"
project. Starting and stopping the watcher and reading my XML file work
fine. Once the watcher is started, I'm reading the text files from the
watched folder line by line into variables and then posting them to a SQL
table.
All of the code for the form is shown below. And it works fine except for 2
issues.
First issue: In the Finally of the Try for teh SQL code I have this:
sqlComm.Connection.Close()
sqlComm.Dispose()
sqlConn.Dispose()
I get this type of intellisense warning: "Variable sqlComm is used before it
has been assigned a value. A null reference exception could result at
runtime." What do I need to rearange to avoid this problem? Sometimes it
causes crash and sometimes not. If the file cannot be opened for some
reason, don't I want to free the sqlComm variable if the code fails?
Second issue (and this is the big problem really): IO errors. I run the
program and then copy and paste 4 text files into the watched folder. They
all get processed exactly as I expect. Everything below appears to run just
fine. Then, without restartign the watcher program, I copy 4 different files
into the watched folder. This time only 2 of them are processed. The other 2
generate the error below:
"The process cannot access the file 'D:\FilesToImport\217068F01.txt' because
it is being used by another process."
Well it's not in use by anything I'm doing manually. I get this error pretty
consistently when I do what I described above. Sometimes 2 files don't work
and sometimes only 1. Sometimes they both process fine but that's very rare.
Usually at least one of them fails. I have no idea why. It doesn't depend on
the particular file either. It's always the first batch (whether it's 1 file
or 30) processes fine after I start up the watcher exe. Then when I drop any
number of additional files into the watched folder 1 or more of them
generate the error above.
I sure hope someone can point out the problems so I can get this running.
I'm pretty frustrated with it right now.
Thanks,
Keith
Here's all the code for this form:
Imports System
Imports System.Xml
Imports System.IO
Imports System.Diagnostics
Imports System.Data.SqlClient
Imports System.Text.RegularExpressions
Public Class NoticeImport
Private watchFolder As FileSystemWatcher
Private dataSource As String, _
dataBase As String, _
userName As String, _
password As String, _
monitoredCustomer As String, _
textFilesLocation As String, _
fntName As String, _
fntSize As Double, _
clipWidth As String
Private Sub Form1_Load(ByVal sender As System.Object, ByVal e As
System.EventArgs) Handles MyBase.Load
btnStartWatching.Enabled = True
btnStopWatching.Enabled = False
Me.Text = "Monitoring for Customer: None"
txtWatchFolder.Text = "Watching Folder: None "
End Sub
Private Sub btnStartWatching_Click(ByVal sender As System.Object, ByVal
e As System.EventArgs) Handles btnStartWatching.Click
watchFolder = New System.IO.FileSystemWatcher()
'Get the db login info and the location of the input text files from
the xml file
Dim sAppPathAndName As String = Application.ExecutablePath
Dim sAppPathOnly As String = Mid(sAppPathAndName, 1,
InStr(sAppPathAndName, "FNTNoticeImport.exe", CompareMethod.Text) - 1)
textFilesLocation = ""
Try
Dim xrdr As New XmlTextReader(sAppPathOnly &
"FNTNoticeImportSettings.xml")
xrdr.WhitespaceHandling = WhitespaceHandling.None
While xrdr.Read()
If String.Compare(xrdr.Name, "dataSource", True) = 0 Then
dataSource = xrdr.ReadElementString()
End If
If String.Compare(xrdr.Name, "dataBase", True) = 0 Then
dataBase = xrdr.ReadElementString()
End If
If String.Compare(xrdr.Name, "userName", True) = 0 Then
userName = xrdr.ReadElementString()
End If
If String.Compare(xrdr.Name, "password", True) = 0 Then
password = xrdr.ReadElementString()
End If
If String.Compare(xrdr.Name, "monitoredCustomer", True) = 0
Then
monitoredCustomer = xrdr.ReadElementString()
End If
If String.Compare(xrdr.Name, "textFilesLocation", True) = 0
Then
textFilesLocation = xrdr.ReadElementString()
End If
If String.Compare(xrdr.Name, "fntName", True) = 0 Then
fntName = xrdr.ReadElementString()
End If
If String.Compare(xrdr.Name, "fntSize", True) = 0 Then
fntSize = xrdr.ReadElementString()
End If
If String.Compare(xrdr.Name, "clipWidth", True) = 0 Then
clipWidth = xrdr.ReadElementString() 'clip width is in
hundredths of an inch
End If
End While
xrdr.Close()
'tell the watcher where to watch
watchFolder.Path = textFilesLocation
Me.Text = "Monitoring for Customer: " & monitoredCustomer
txtWatchFolder.Text = "Watching Folder: " & textFilesLocation
'add a list of Filter we want to specify
'make sure you use OR for each Filter as we need to all of those
watchFolder.NotifyFilter = IO.NotifyFilters.DirectoryName
watchFolder.NotifyFilter = watchFolder.NotifyFilter Or
IO.NotifyFilters.FileName
watchFolder.NotifyFilter = watchFolder.NotifyFilter Or
IO.NotifyFilters.Attributes
' add the handler to each event
AddHandler watchFolder.Changed, AddressOf logChange
AddHandler watchFolder.Created, AddressOf logChange
AddHandler watchFolder.Deleted, AddressOf logChange
' add the rename handler as the signature is different
AddHandler watchFolder.Renamed, AddressOf logrename
'Set this property to true to start watching
watchFolder.EnableRaisingEvents = True
watchFolder.IncludeSubdirectories = False
watchFolder.Filter = "*.txt"
btnStartWatching.Enabled = False
btnStopWatching.Enabled = True
Catch ex As XmlException
MsgBox("XML Error " & ex.Message & " occurred. Cannot start
watching process.")
Exit Sub
Catch ex As Exception
MsgBox("Error " & ex.Message & " occurred. Cannot start watching
process.")
Exit Sub
End Try
End Sub
Private Sub logChange(ByVal source As Object, ByVal e As
System.IO.FileSystemEventArgs)
'Don't use this for now
'If e.ChangeType = IO.WatcherChangeTypes.Changed Then
' txtFolderActivity.Text &= "File " & e.FullPath & " has been
modified" & vbCrLf
'End If
If e.ChangeType = IO.WatcherChangeTypes.Created Then
'txtFolderActivity.Text &= e.Name & " received at " & Now() &
vbCrLf
If InStr(e.Name, ".txt", CompareMethod.Text) Then
Call ImportTextFiles(e.Name)
'Debug.Print(e.Name)
End If
End If
'Don't use this for now
'If e.ChangeType = IO.WatcherChangeTypes.Deleted Then
' txtFolderActivity.Text &= "File " & e.FullPath & " has been
deleted" & vbCrLf
'End If
End Sub
Public Sub logrename(ByVal source As Object, ByVal e As
System.IO.RenamedEventArgs)
'Don't use this for now
'txtFolderActivity.Text &= "File" & e.OldName & " has been renamed
to " & e.Name & vbCrLf
End Sub
Private Sub btnStopWatching_Click(ByVal sender As System.Object, ByVal e
As System.EventArgs) Handles btnStopWatching.Click
' Stop watching the folder
watchFolder.EnableRaisingEvents = False
btnStartWatching.Enabled = True
btnStopWatching.Enabled = False
Me.Text = "Monitoring for Customer: None"
txtWatchFolder.Text = "Watching Folder: None "
End Sub
Private Sub ImportTextFiles(ByVal sFileToImport As String)
'Process the file
Dim dfc As New DlnpFntCalcs.DlnpFntCalcs
Dim srLine As String
Dim iFileLineCount As Integer, _
iNoticeTextLineCount As Integer
Dim bInNoticeText As Boolean
Dim AdTypeCode As String, _
ImportType As String, _
AttorneyFileNum As String, _
AttyOfficeName As String, _
MortgagorFirstName As String, _
MortgagorLastName As String, _
PropAddress1 As String, _
PropAddress2 As String, _
PropCity As String, _
PropState As String, _
PropZip As String, _
FirstPubDate As String, _
NumWeeksToRun As String, _
LastPubDate As String, _
County As String, _
DateOfSale As String, _
FullNoticeText As String, _
NoticeTextHeight As Double, _
WholeImportFile As String
ImportType = ""
AttorneyFileNum = ""
AttyOfficeName = ""
MortgagorFirstName = ""
MortgagorLastName = ""
PropAddress1 = ""
PropAddress2 = ""
PropCity = ""
PropState = ""
PropZip = ""
FirstPubDate = ""
NumWeeksToRun = ""
LastPubDate = ""
County = ""
DateOfSale = ""
FullNoticeText = ""
WholeImportFile = ""
bInNoticeText = False
iFileLineCount = 0
iNoticeTextLineCount = 0
Dim sr As StreamReader
'Open the text file
Try
sr = New StreamReader(textFilesLocation & sFileToImport)
Catch ex As Exception
txtFolderActivity.Text &= "Error " & ex.Message & " occurred
while trying to open file " & sFileToImport & ". File NOT imported (" &
Format(Now(), "m/d/yy hh:mm:ss") & ")." & vbCrLf
Exit Sub
End Try
'Read the text file line by line
Try
Do
srLine = sr.ReadLine()
iFileLineCount += 1
If iFileLineCount = 1 Then
WholeImportFile = srLine
Else
WholeImportFile = WholeImportFile & vbCrLf & srLine
End If
'TODO 2008-08-13 - AdTypeCode will need to come from import
file at some point
AdTypeCode = "M"
'If InStr(srLine, "Ad Tpe:", CompareMethod.Text) Then
' AdTypeCode = Trim(Mid(srLine, 8))
'End If
If InStr(srLine, "Publication Notice:", CompareMethod.Text)
Then
ImportType = Trim(Mid(srLine, 20))
End If
If InStr(srLine, "File Number:", CompareMethod.Text) Then
AttorneyFileNum = Trim(Mid(srLine, 13))
End If
'TODO 2008-08-13 - AttorneyName will need to come from
import file at some point when we use this for other attorneys
If InStr(srLine, "Team:", CompareMethod.Text) Then
AttyOfficeName = Trim(Mid(srLine, 6))
AttyOfficeName = "Trott & Trott P.C. (team " &
AttyOfficeName & ")"
End If
If InStr(srLine, "Mortgagor First:", CompareMethod.Text)
Then
MortgagorFirstName = Trim(Mid(srLine, 17))
End If
If InStr(srLine, "Mortgagor Last:", CompareMethod.Text) Then
MortgagorLastName = Trim(Mid(srLine, 16))
End If
If InStr(srLine, "Property Address 1:", CompareMethod.Text)
Then
PropAddress1 = Trim(Mid(srLine, 20))
End If
If InStr(srLine, "Property Address 2:", CompareMethod.Text)
Then
PropAddress2 = Trim(Mid(srLine, 20))
End If
If InStr(srLine, "City:", CompareMethod.Text) Then
PropCity = Trim(Mid(srLine, 6))
End If
If InStr(srLine, "State:", CompareMethod.Text) Then
PropState = Trim(Mid(srLine, 7))
End If
If InStr(srLine, "ZIP:", CompareMethod.Text) Then
PropZip = Trim(Mid(srLine, 5))
End If
If InStr(srLine, "First Publication Date:",
CompareMethod.Text) Then
FirstPubDate = Trim(Mid(srLine, 24))
End If
If InStr(srLine, "Number Of Insertions:",
CompareMethod.Text) Then
NumWeeksToRun = Trim(Mid(srLine, 22))
End If
If InStr(srLine, "Last Pub Date:", CompareMethod.Text) Then
LastPubDate = Trim(Mid(srLine, 15))
End If
If InStr(srLine, "County:", CompareMethod.Text) Then
County = Trim(Mid(srLine, 8))
End If
If InStr(srLine, "Sale Date:", CompareMethod.Text) Then
DateOfSale = Trim(Mid(srLine, 11))
End If
'TODO 2008-08-07 - only do the following if it's new or
correction (not if cancel)
If InStr(srLine, "*** Begin Notice ***", CompareMethod.Text)
Quote:
Originally Posted by
0 Then
'skip 1 line and read the rest into the FullNoticeText
variable
srLine = sr.ReadLine()
iNoticeTextLineCount = 1 'we're on line one now and will
get it into FullNoticeText below
WholeImportFile = WholeImportFile & vbCrLf & srLine
'have to do this here because we're skipping a line. if we don't then the
similar line above won't catch the skipped line
bInNoticeText = True
End If
If bInNoticeText Then
If InStr(srLine, "*** End Notice ***",
CompareMethod.Text) = 0 Then
If iNoticeTextLineCount = 1 Then
FullNoticeText = srLine
Else
FullNoticeText = FullNoticeText & vbCrLf &
srLine
End If
iNoticeTextLineCount += 1
End If
End If
Loop Until InStr(srLine, "*** End Notice ***",
CompareMethod.Text) <0
'If this is a correction, then there is info AFTER the "*** End
Notice ***" line that we need to read into the WholeImportFile variable
If String.Compare(ImportType, "Correct", True) = 0 Then
WholeImportFile = WholeImportFile & vbCrLf & sr.ReadToEnd()
End If
Catch ex As Exception
txtFolderActivity.Text &= "Error " & ex.Message & " occurred
while trying to read file " & sFileToImport & ". File NOT imported (" &
Format(Now(), "m/d/yy hh:mm:ss") & ")." & vbCrLf
Exit Sub
Finally
'do not need sr after all the above reading is done
sr.Close()
sr.Dispose()
End Try
'get the height in decimal inches (rounded to 2 places)
Try
If FullNoticeText <"" Then
NoticeTextHeight = (dfc.NoticeTextHeight(FullNoticeText,
fntName, fntSize, clipWidth))
Else
NoticeTextHeight = 0
End If
Catch ex As Exception
txtFolderActivity.Text &= "Error " & ex.Message & " occurred
while calling dll to get text height on file " & sFileToImport & ". File NOT
imported (" & Format(Now(), "m/d/yy hh:mm:ss") & ")." & vbCrLf
Exit Sub
End Try
Dim sqlConn As SqlConnection
Dim sqlComm As SqlCommand
'get the data into the database
Try
sqlConn = New SqlConnection("Data Source=" & dataSource &
";Initial Catalog=" & dataBase & ";User Id=" & userName & ";Password=" &
password & ";")
sqlConn.Open()
sqlComm = New SqlCommand("sp_ImportNotices", sqlConn)
sqlComm.CommandType = CommandType.StoredProcedure
sqlComm.Parameters.Add("RETURN_VALUE", SqlDbType.Int).Value = 0
sqlComm.Parameters("RETURN_VALUE").Direction =
ParameterDirection.ReturnValue
sqlComm.Parameters.Add("@AdTypeCode", SqlDbType.VarChar,
50).Value = IIf(AdTypeCode = "", DBNull.Value, AdTypeCode)
sqlComm.Parameters.Add("@ImportType", SqlDbType.VarChar,
50).Value = IIf(ImportType = "", DBNull.Value, ImportType)
sqlComm.Parameters.Add("@AttorneyFileNum", SqlDbType.VarChar,
50).Value = IIf(AttorneyFileNum = "", DBNull.Value, AttorneyFileNum)
sqlComm.Parameters.Add("@AttyOfficeName", SqlDbType.VarChar,
200).Value = IIf(AttyOfficeName = "", DBNull.Value, AttyOfficeName)
sqlComm.Parameters.Add("@MortgagorFirstName", SqlDbType.VarChar,
50).Value = IIf(MortgagorFirstName = "", DBNull.Value, MortgagorFirstName)
sqlComm.Parameters.Add("@MortgagorLastName", SqlDbType.VarChar,
50).Value = IIf(MortgagorLastName = "", DBNull.Value, MortgagorLastName)
sqlComm.Parameters.Add("@PropAddress1", SqlDbType.VarChar,
100).Value = IIf(PropAddress1 = "", DBNull.Value, PropAddress1)
sqlComm.Parameters.Add("@PropAddress2", SqlDbType.VarChar,
100).Value = IIf(PropAddress2 = "", DBNull.Value, PropAddress2)
sqlComm.Parameters.Add("@PropCity", SqlDbType.VarChar,
100).Value = IIf(PropCity = "", DBNull.Value, PropCity)
sqlComm.Parameters.Add("@PropState", SqlDbType.VarChar,
50).Value = IIf(PropState = "", DBNull.Value, PropState)
sqlComm.Parameters.Add("@PropZip", SqlDbType.VarChar, 20).Value
= IIf(PropZip = "", DBNull.Value, PropZip)
sqlComm.Parameters.Add("@FirstPubDate", SqlDbType.VarChar,
50).Value = IIf(FirstPubDate = "", DBNull.Value, FirstPubDate)
sqlComm.Parameters.Add("@NumWeeksToRun", SqlDbType.VarChar,
10).Value = IIf(NumWeeksToRun = "", DBNull.Value, NumWeeksToRun)
sqlComm.Parameters.Add("@LastPubDate", SqlDbType.VarChar,
50).Value = IIf(LastPubDate = "", DBNull.Value, LastPubDate)
sqlComm.Parameters.Add("@County", SqlDbType.VarChar, 50).Value =
IIf(County = "", DBNull.Value, County)
sqlComm.Parameters.Add("@DateOfSale", SqlDbType.VarChar,
50).Value = IIf(DateOfSale = "", DBNull.Value, DateOfSale)
sqlComm.Parameters.Add("@FullNoticeText", SqlDbType.Text).Value
= IIf(FullNoticeText = "", DBNull.Value, FullNoticeText)
sqlComm.Parameters.Add("@NoticeTextHeight", SqlDbType.Decimal,
5).Value = CDbl(NoticeTextHeight)
sqlComm.Parameters.Add("@WholeImportFile", SqlDbType.Text).Value
= IIf(WholeImportFile = "", DBNull.Value, WholeImportFile)
sqlComm.Parameters.Add("@TextFileName", SqlDbType.VarChar,
500).Value = sFileToImport
sqlComm.Parameters.Add("@ReasonsNotPosted", SqlDbType.VarChar,
500).Value = DBNull.Value
sqlComm.Parameters("@ReasonsNotPosted").Direction =
ParameterDirection.Output
sqlComm.ExecuteNonQuery()
If sqlComm.Parameters("RETURN_VALUE").Value <0 Then
txtFolderActivity.Text &= "SQL Error " &
sqlComm.Parameters("RETURN_VALUE").Value.ToString & " on file " &
sFileToImport & ". File NOT imported (" & Format(Now(), "m/d/yy hh:mm:ss") &
")." & vbCrLf
Exit Sub
End If
Catch ex As SqlException
txtFolderActivity.Text &= "SQL Error " & ex.Message & " occurred
while executing SQL procedure sp_ImportNotices on file " & sFileToImport &
". File NOT imported (" & Format(Now(), "m/d/yy hh:mm:ss") & ")." & vbCrLf
Exit Sub
Catch ex As Exception
txtFolderActivity.Text &= "Error " & ex.Message & " occurred
while executing SQL procedure sp_ImportNotices on file " & sFileToImport &
". File NOT imported (" & Format(Now(), "m/d/yy hh:mm:ss") & ")." & vbCrLf
Exit Sub
Finally
sqlComm.Connection.Close()
sqlComm.Dispose()
sqlConn.Dispose()
End Try
'if the "ImportedNoticeFiles" folder does not yet exist, create it
Try
If Not Directory.Exists(textFilesLocation &
"ImportedNoticeFiles") Then
Directory.CreateDirectory(textFilesLocation &
"ImportedNoticeFiles")
'don't go on until the folder has been created
Do Until Directory.Exists(textFilesLocation &
"ImportedNoticeFiles")
System.Threading.Thread.Sleep(500)
Loop
End If
Catch ex As IOException
txtFolderActivity.Text &= "IO Error " & ex.Message & "
attempting to create ImportedNoticeFiles folder while importing file " &
sFileToImport & ". File NOT imported (" & Format(Now(), "m/d/yy hh:mm:ss") &
")." & vbCrLf
End Try
'store the finished file in the ImportedNoticeFiles folder for
someone to manually review (delete it first if for some reason it already
exists)
Try
If File.Exists(textFilesLocation & "ImportedNoticeFiles\" &
sFileToImport) Then
File.Delete(textFilesLocation & "ImportedNoticeFiles\" &
sFileToImport)
'Need to wait for the file to be deleted before moving on.
Do Until Not File.Exists(textFilesLocation &
"ImportedNoticeFiles\" & sFileToImport)
System.Threading.Thread.Sleep(500)
Loop
End If
Catch ex As IOException
txtFolderActivity.Text &= "File " & sFileToImport & " was
imported but IO Error " & ex.Message & " occurred while attempting to delete
the previously imported file with the same name (" & Format(Now(), "m/d/yy
hh:mm:ss") & ")." & vbCrLf
Exit Sub
End Try
Try
File.Move(textFilesLocation & sFileToImport, textFilesLocation &
"ImportedNoticeFiles\" & sFileToImport)
Catch ex As IOException
txtFolderActivity.Text &= "IO Error " & ex.Message & " occurred
while attempting to move file " & sFileToImport & " to the
ImportedNoticeFiles folder. File NOT imported (" & Format(Now(), "m/d/yy
hh:mm:ss") & ")." & vbCrLf
Exit Sub
End Try
txtFolderActivity.Text &= "File " & sFileToImport & " has been
imported successfully and has been moved to the ImportedNoticeFiles
subfolder (" & Format(Now(), "m/d/yy hh:mm:ss") & ")." & vbCrLf
End Sub
End Class
